Added Django Skeleton #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2017 01:35
It is working, but only when settings is left with its vars.
Ex: I've tried to remove SECRET_KEY from settings.py and got:
raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.
It is working, but only when settings is left with its vars.
Ex: I've tried to remove SECRET_KEY from settings.py and got:
raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.
Closed
renzon
force-pushed
the
django_extension
branch
from
2dfaac9
to
e040b04
Compare
mazulo
reviewed
Oct 25, 2017
| @@ -1,5 +1,5 @@ | |||
| from django.apps import AppConfig | |||
|
|
|||
|
|
|||
| class BarConfig(AppConfig): | |||
| class DJangoDynaconfig(AppConfig): | |||
There was a problem hiding this comment.
I think we have a little typo in the class name
There was a problem hiding this comment.
I tried I little merge with Dynaconf with Config, but maybe I've failed ;)
There was a problem hiding this comment.
i think @mazulo is refering to "DJango..." instead of "Django"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is working, but only when settings is left with its vars.
Ex: I've tried to remove SECRET_KEY from settings.py and got:
raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.
Now I got what you mean we need to keep standard DJANGO var on settings.py, only to please the health check of the project. On your second solution, patching manage.py and wsgi.py are the var also necessary on settings.py? If not, I would go with the second solution ;)