Fix #443 object merge with same value on same level keys #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution is a temporary solution as it solves current problem, but there is still the case for `None` values. The best solution for this case would be wrapping all the values on assignment and give it a full path signature to compare.
rochacbruno
commented
Oct 7, 2020
| if ( | ||
| existing_value is not None | ||
| and key == full_path[-1] | ||
| and existing_value is value |
There was a problem hiding this comment.
This line is still buggy as this comparison cannot handle None types.
To improve this we need to create a way to have a unique signature for each value.
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 846 846
=========================================
Hits 846 846
Continue to review full report at Codecov.
|
rochacbruno
added a commit
that referenced
this pull request
Oct 8, 2020
Shortlog of commits since last release:
Bruno Rocha (13):
Release version 3.1.1
Update diagram images
Update docs/release_notes
Fixing prospector warnings. (#425)
Fix mkdocs config problem found in #423
Signed in for https://xscode.com/rochacbruno/dynaconf (#426)
Remove links to outdated issues from guidelines
Fix colors and KEyError handling on cli.py (#429)
Fix #434 setenv failing to unset LazyValues (#437)
Fix #432 no need for warning when env is missing on a file (#438)
Add test to ensure fix #430 (#439)
Close #284 not a bug (#440)
Fix #443 object merge with same value on same level keys (#444)
dependabot-preview[bot] (6):
Bump mkdocs-material from 5.3.2 to 5.5.13 (#423)
Bump pymdown-extensions from 7.1 to 8.0 (#422)
Bump mkdocs-material-extensions from 1.0 to 1.0.1 (#427)
Bump pymdown-extensions from 8.0 to 8.0.1 (#435)
Bump mkdocs-material from 5.5.13 to 6.0.1 (#436)
Bump mkdocs-material from 6.0.1 to 6.0.2 (#442)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is a temporary solution as it solves current
problem, but there is still the case for
Nonevalues.The best solution for this case would be wrapping all the values
on assignment and give it a full path signature to compare.
Fix #443