Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load YAML from external files with no summary/description. Fixes #93 #160

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Conversation

schamp
Copy link
Contributor

@schamp schamp commented Oct 10, 2017

If there's no '---' in the text, but it's from an external file, assume
it's all YAML, but if it's not from an external file, assume there is no
YAML (i.e., it's all docstring).

@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 90.401% when pulling d4a998e on schamp:master into 7dc5135 on rochacbruno:master.

@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage decreased (-0.06%) to 90.544% when pulling 221dec2 on schamp:master into 7dc5135 on rochacbruno:master.

@schamp
Copy link
Contributor Author

schamp commented Oct 10, 2017

I think the only other way to increase the coverage is to add test cases that reference external YAML files that have no swagger spec in them, just a description. Not sure how helpful that will be...

Andrew Schamp added 2 commits October 10, 2017 19:24
If there's no '---' in the text, but it's from an external file, assume
it's all YAML, but if it's not from an external file, assume there is no
YAML (i.e., it's all docstring).
But they are duplicates in the examples, and may not be helpful.  It
wasn't clear how best to get these into the tests otherwise.
@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+0.07%) to 90.674% when pulling e611e6d on schamp:master into 7dc5135 on rochacbruno:master.

@schamp
Copy link
Contributor Author

schamp commented Oct 10, 2017

Found a bug, going to clean up that first commit and try again.

@schamp schamp closed this Oct 10, 2017
@schamp
Copy link
Contributor Author

schamp commented Oct 10, 2017

Forgive the churn, I'm new at this.

@schamp schamp reopened this Oct 10, 2017
@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+0.07%) to 90.674% when pulling e611e6d on schamp:master into 7dc5135 on rochacbruno:master.

@rochacbruno rochacbruno merged commit 088aedb into flasgger:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants