Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update imports to support apispec>=0.39.0 #205

Merged
merged 2 commits into from Jul 30, 2018
Merged

Update imports to support apispec>=0.39.0 #205

merged 2 commits into from Jul 30, 2018

Conversation

v-francoise
Copy link
Contributor

Following the apispec upgrade from 0.38.0 to 0.39.0, its
swagger.py was renamed to openapi.py with support for OpenAPI 3.0.X
as well as OpenAPI 2.0.

In this commit, I only fix the backward-incompatible changed it
introduced without trying to add support for 3.0.X version.

See marshmallow-code/apispec@0.38.0...0.39.0

Update imports to support apispec>=0.39.0
54d9e77 
Following the apispec upgrade from 0.38.0 to 0.39.0, its
swagger.py was renamed to openapi.py with support for OpenAPI 3.0.X
as well as OpenAPI 2.0.

In this commit, I only fix the backward-incompatible changed it
introduced without trying to add support for 3.0.X version.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.489% when pulling 54d9e77 on v-francoise:bug/support-new-apispec into 6bdacba on rochacbruno:master.

@coveralls
Copy link

coveralls commented Jun 29, 2018 •
edited

Coverage Status

Coverage increased (+0.04%) to 90.489% when pulling 370e67c on v-francoise:bug/support-new-apispec into 6bdacba on rochacbruno:master.

@rochacbruno
Copy link
Member

I think requirements must pin to apispec>=0.39.0

@v-francoise
Copy link
Contributor Author

@rochacbruno Is it ok like this?

@rochacbruno
Copy link
Member

@v-francoise yeah I gonna run some tests and merge it!

javabrett
javabrett approved these changes Jul 3, 2018
View reviewed changes
Copy link
Collaborator

@javabrett javabrett left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me. I guess the alternative is to lock apispec to the older version.

Without this change I now get (since the new apispec release and with some debug code added):

No module named 'apispec.ext.marshmallow.swagger'

requirements-dev.txt
-e .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your editor added a \n.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javabrett yeah it seems so, if @rochacbruno you want to have it removed, I can do it.

@rochacbruno rochacbruno merged commit 622ac1e into flasgger:master Jul 30, 2018
@rochacbruno rochacbruno mentioned this pull request Jul 30, 2018
Closed
@javabrett javabrett mentioned this pull request Aug 26, 2018
Closed
This was referenced Sep 7, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javabrett javabrett javabrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@v-francoise @coveralls @rochacbruno @javabrett