Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tests #310

Merged
merged 1 commit into from Jul 25, 2019
Merged

Fix for tests #310

merged 1 commit into from Jul 25, 2019

Conversation

belkka
Copy link
Contributor

@belkka belkka commented Jun 7, 2019

Currently tests are broken.

(venv) ~/projects/flasgger$ git status
On branch master
Your branch is up to date with 'origin/master'.
 
nothing to commit, working tree clean
(venv) ~/projects/flasgger$ make test
...
make: *** [test] Error 2

https://pastebin.com/puUDPZqH

This PR fixes the problem.

Change summary: pass schema_name_resolver=lambda schema: None instead of schema_name_resolver=None to OpenAPIConverter constructor

See also: #285

Pass `schema_name_resolver=lambda schema: None` to `OpenAPIConverter` constructor
@belkka belkka changed the title Update marshmallow_apispec.py Fix for tests Jun 7, 2019
Copy link
Contributor

@roo-oliv roo-oliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@billyrrr billyrrr merged commit 038fe9b into flasgger:master Jul 25, 2019
@kushan-gunasekera
Copy link

Thanks to this merge, it fixed issue #285. When I install flasgger using master branch, I got this error.

Collecting https://github.com/rochacbruno/flasgger/tarball/master
  Downloading https://github.com/rochacbruno/flasgger/tarball/master
     \ 5.2MB 537kB/s
Requirement already satisfied: Flask>=0.10 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from flasgger==0.9.3.dev0) (1.1.1)
Requirement already satisfied: PyYAML>=3.0 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from flasgger==0.9.3.dev0) (5.1.1)
Requirement already satisfied: jsonschema>=2.5.1 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from flasgger==0.9.3.dev0) (3.0.1)
Requirement already satisfied: mistune in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from flasgger==0.9.3.dev0) (0.8.4)
Requirement already satisfied: six>=1.10.0 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from flasgger==0.9.3.dev0) (1.12.0)
Requirement already satisfied: click>=5.1 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from Flask>=0.10->flasgger==0.9.3.dev0) (7.0)
Requirement already satisfied: itsdangerous>=0.24 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from Flask>=0.10->flasgger==0.9.3.dev0) (1.1.0)
Requirement already satisfied: Jinja2>=2.10.1 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from Flask>=0.10->flasgger==0.9.3.dev0) (2.10.1)
Requirement already satisfied: Werkzeug>=0.15 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from Flask>=0.10->flasgger==0.9.3.dev0) (0.15.5)
Requirement already satisfied: setuptools in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from jsonschema>=2.5.1->flasgger==0.9.3.dev0) (41.0.1)
Requirement already satisfied: pyrsistent>=0.14.0 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from jsonschema>=2.5.1->flasgger==0.9.3.dev0) (0.15.3)
Requirement already satisfied: attrs>=17.4.0 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from jsonschema>=2.5.1->flasgger==0.9.3.dev0) (19.1.0)
Requirement already satisfied: MarkupSafe>=0.23 in /home/wasdkiller/.local/share/virtualenvs/pgssa-products-service-UeKXU2lw/lib/python3.6/site-packages (from Jinja2>=2.10.1->Flask>=0.10->flasgger==0.9.3.dev0) (1.1.1)
Building wheels for collected packages: flasgger
  Building wheel for flasgger (setup.py) ... done
  Stored in directory: /tmp/pip-ephem-wheel-cache-jgx0gns2/wheels/5c/e9/48/d33323c6e48990d2c7e9883d8772ecb49cf3c80d6b17ca7501
Successfully built flasgger
ERROR: flasgger 0.9.3.dev0 has requirement jsonschema<3.0.0, but you'll have jsonschema 3.0.1 which is incompatible.
Installing collected packages: flasgger
  Found existing installation: flasgger 0.9.2
    Uninstalling flasgger-0.9.2:
      Successfully uninstalled flasgger-0.9.2
Successfully installed flasgger-0.9.3.dev0

Should I ignore this ERROR: flasgger 0.9.3.dev0 has requirement jsonschema<3.0.0, but you'll have jsonschema 3.0.1 which is incompatible. error?

@billyrrr
Copy link
Member

Hi, Kushan. Could you submit it as an issue? I've also encountered the error/warning for jsonschema. I'll look into ways of resolving it tomorrow. Thank you.

@kushan-gunasekera
Copy link

Yha sure @billyrrr , I'll add it as an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants