Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for issue #311 #312

Closed
wants to merge 5 commits into from
Closed

Solution for issue #311 #312

wants to merge 5 commits into from

Conversation

isaacfi
Copy link

@isaacfi isaacfi commented Jun 24, 2019

To solve the issue Issue 311 I loaded the main_def from file using $ref property and absolute application path

Sorry for all changes, but it pretend to solve the issue flasgger#311 I loaded the main_def from file
@pep8speaks
Copy link

pep8speaks commented Jun 24, 2019

Hello @isaacfi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-10 02:12:33 UTC

@isaacfi
Copy link
Author

isaacfi commented Jun 24, 2019

I think that is a mistake while pasting the code, let me delete the blank line

I've wrote a better solution replacing the references '$ref' with the recursive method __replace_ref
@isaacfi
Copy link
Author

isaacfi commented Jul 10, 2019

Please accept my solution: @rochacbruno

absolute_path = os.path.dirname(sys.argv[0])
new_value = {}
for key, value in schema.items():
print('key:', key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaacfi Could you delete the print statements? Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course I forgot to delete them

billyrrr referenced this pull request Aug 8, 2019
commit f77ea0a
Author: Isaac Hernandez <isaacfi@gmail.com>
Date:   Tue Jul 9 21:12:29 2019 -0500

    Improvement solution for issue 311

    I've wrote a better solution replacing the references '$ref' with the recursive method __replace_ref

commit 3cb03f4
Author: Isaac Hernandez <isaacfi@gmail.com>
Date:   Mon Jun 24 08:52:34 2019 -0500

    Fix index

commit bdcfd33
Author: Isaac Hernandez <isaacfi@gmail.com>
Date:   Mon Jun 24 08:51:30 2019 -0500

    Validate if the referenced schema has divider

commit bf9c17e
Author: Isaac Hernandez <isaacfi@gmail.com>
Date:   Sun Jun 23 23:31:04 2019 -0500

    Remove the spaces in 361 line

commit bf262df
Author: Isaac Hernandez <isaacfi@gmail.com>
Date:   Sun Jun 23 23:16:13 2019 -0500

    Solution for issue #311

    Sorry for all changes, but it pretend to solve the issue #311 I loaded the main_def from file
@billyrrr
Copy link
Member

billyrrr commented Aug 8, 2019

Hi, @isaacfi . I have merged your commit into the master branch in this commit Please let me know if you have any questions. Thank you for your contribution.

@billyrrr billyrrr closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants