Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not search for global properties on local node #97

Closed
wants to merge 50 commits into from

Conversation

tobixx
Copy link
Contributor

@tobixx tobixx commented Apr 28, 2017

In the case the proposed fix in #96 is sufficient, I going to make it more simply for you by just hitting the button ;-)

@coveralls
Copy link

coveralls commented Apr 28, 2017

Coverage Status

Coverage decreased (-0.2%) to 81.887% when pulling c732fc6 on tobixx:fix-global-properties into a9b0867 on rochacbruno:master.

@rochacbruno
Copy link
Member

This PR breaks the examples:
python demo_app/app.py --debug

http://localhost:5000/validation/apidocs/#!/users/post_schemevalidation

and

http://localhost:5000/validation/apidocs/#!/users/post_blueprint_schemevalidation

I need to find a way to make it work with the changes you proposed, but first I need to understand better the reason of your change.

rochacbruno and others added 19 commits May 8, 2017 19:48
Add support for vendor extensions in top-level config.
* Add support for decorating the Flasgger views

* Fix name of test endpoint
* Remove hardcoded specs_route from conftest

* Custom specs_route example
* Remove hardcoded specs_route from conftest

* Enable/Disable Swagger UI through config

* Make it backwards compatible

* Disable Swagger UI example

* Update README
Rodrigo Martins de Oliveira and others added 19 commits June 26, 2017 12:54
* Support validation against specs in docstrings

* Update README

* Tests
examples are in examples/package_example
@talitarossari may help us to reproduce it there :)
* get_schema

* tests

* Documentation

* Python 2.7 compatibility
* Custom validation functions support

* Further tests

* Emend README
* Update static UI files

* updated history

* bum version 0.6.6
…on-error-handling

Document Validation Error Handler
So we can keep a clean separation of what is needed in production and
development.
* Fix typo

* Update restful.py
@sebb0
Copy link

sebb0 commented Sep 20, 2017

My team ran into the same problem as @tobixx. And this PR is fixing the problem for us.

@rochacbruno
Copy link
Member

@sebb0 I need to ensure the demo_app/app.py works so I need this PR to updated with a solution or making it optional.

rochacbruno and others added 4 commits September 28, 2017 19:36
Thanks to @SBillion who noticed that this would break things if user
has another custom JSONEncoder already set.
Now the user should set it explicitly.
@tobixx tobixx closed this Oct 5, 2017
@tobixx tobixx deleted the fix-global-properties branch October 5, 2017 14:58
@tobixx tobixx restored the fix-global-properties branch October 5, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet