Support to python3 #190
Support to python3 #190
Conversation
Hypknowsys master
ghost
assigned 
|
👍 |
1 similar comment
|
+1 |
|
👍 very nice! @alexandre I will take a closer look and merge soon! |
|
I'm updating the PR with the new feature (RSS) and keeping the python3 support. There are some PEP8 warnings, I'll fix it too, ok? |
|
nice one! |
| markupsafe | ||
| Pillow | ||
| pyyaml | ||
| speaklater | ||
| https://github.com/pythonhub/quokka-themes/tarball/master | ||
| https://github.com/alexandre/quokka-themes/tarball/master |
There was a problem hiding this comment.
I merged your fork with quokkaproject/quokka-themes
| @@ -40,7 +40,8 @@ def inner(*args, **kwargs): | |||
| def _get(self): | |||
| def inner(*args, **kwargs): | |||
| values = only_matches(self, kwargs) | |||
| if len(values) > 1: | |||
| values = list(values) | |||
| if len(list(values)) > 1: | |||
There was a problem hiding this comment.
We need to perform this cast twice?
Why not just?
values = list(values)
if len(values) > 1:There was a problem hiding this comment.
We should refactor this piece...I didn't see that because I did keep my focus on python3 support.
I'll fix this flags. =]
There was a problem hiding this comment.
Cool.
BTW is a great job, congratulations 👏 .
|
@alexandre the twill author answered your email? we need to merge this PR soon, before code changes a lot. I want to include your changes, only need to know what to do about twill and decide about the unicode issue above. |
|
@rochacbruno no email after that one. I think you can keep the repo on quokkaproject. I stop [for a moment] my commits because personal problems (laptop broken). But I'll work on this today. [ ]'s (hugs) |
1 similar comment
|
updated |
| forbidden = False | ||
| break # break in first occurence | ||
| forbidden = next( | ||
| (True for role in user.roles if role in user.roles), False) |
There was a problem hiding this comment.
I guess there is a problem here:
the loop should iterate channel.roles
There was a problem hiding this comment.
I will merge, and then try to think in a way to write a test for this feature.
All tests are passing, but I'm referencing some own repositories while I not receive a feedback about my others PR.
I've created a repository for the twill with support to python3 (2to3) and I would like to pass this repository to the quokkaproject profile, if you want...of course.