Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite #10

Closed
swkeemink opened this issue May 26, 2017 · 1 comment · Fixed by #202
Closed

Update test suite #10

swkeemink opened this issue May 26, 2017 · 1 comment · Fixed by #202
Assignees

Comments

@swkeemink
Copy link
Member

The test suite is now significantly out-of-date with the actual FISSA functions. This should be updated.

@swkeemink swkeemink self-assigned this Feb 14, 2018
@scottclowe
Copy link
Member

There have been updates to the test suite since, particularly in PRs #35 and #62. Further tests are added in #54.

Some of these tests are very solid, in particular since creating and adding the test resources https://github.com/rochefort-lab/fissa/tree/master/fissa/tests/resources/a.

However, some of my tests are still rather lose, and could do with more work. In particular, the matlab file generation test only check whether the code executes and doesn't inspect the output. The neuropil tests also only check the code executes and the output has the right shape, without checking its exact contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants