Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reason Replicache performance is absurdly bad when Chrome dev tools is open #634

Closed
aboodman opened this issue Oct 27, 2021 · 5 comments
Assignees

Comments

@aboodman
Copy link
Contributor

All the perf tests decrease like 5x-10x (!!). I have no idea what is going on but this is a common thing for developers to experience since they basically work with devtools open. We need to figure this out.

@aboodman
Copy link
Contributor Author

Fixit to investigate. This was reported by calvin of Eleventh.

@aboodman aboodman self-assigned this Nov 19, 2021
@aboodman
Copy link
Contributor Author

Alright, I figured this out!

Screen Shot 2021-11-19 at 10 27 04 AM

-- https://developer.chrome.com/blog/wasm-debugging-2020/

In the following screencap, the top run is with devtools open, the second is with it closed:
screen_shot_2021-11-19_at_10 21 38_am

So our hashing is over 10x slower with devtools open because of this "tiering down" behavior in Chrome.

@aboodman
Copy link
Contributor Author

OK what we've decided to do here is switch back to the native hash function (see #605 ) so closing this.

@aboodman aboodman reopened this Dec 2, 2021
@aboodman
Copy link
Contributor Author

aboodman commented Dec 2, 2021

Guess it make sense to leave open until fixed.

@grgbkr
Copy link
Contributor

grgbkr commented Jan 13, 2022

Fixed by a388706

@grgbkr grgbkr closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants