fix(roc-plugin-repo): Solved issue when doing collected releases

Before the table would not display the correct data and fail to render scoped packages.
rocjs · Oct 3, 2017 · 3ad7bad · 3ad7bad
1 parent 46395f1
commit 3ad7bad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/extensions/roc-plugin-repo/src/commands/release.js b/extensions/roc-plugin-repo/src/commands/release.js
@@ -348,6 +348,7 @@ export default projects => ({
                       selectedToBeReleased.map(async project => {
                         const releaseText = await createGithubReleaseText(
                           [project],
+                          status,
                           isMonorepo,
                           individual,
                           from,
@@ -366,6 +367,7 @@ export default projects => ({
 
                   ctx.releaseText = await createGithubReleaseText(
                     selectedToBeReleased,
+                    status,
                     isMonorepo,
                     individual,
                     from,

diff --git a/extensions/roc-plugin-repo/src/semver/createGithubReleaseText.js b/extensions/roc-plugin-repo/src/semver/createGithubReleaseText.js
@@ -10,6 +10,7 @@ import {
 
 export default async function createGithubReleaseText(
   projects,
+  status,
   isMonorepo,
   individual,
   from,
@@ -33,7 +34,7 @@ export default async function createGithubReleaseText(
     isMonorepo,
     projects,
   );
-  const projectTable = individual ? '' : createTable(projects);
+  const projectTable = individual ? '' : createTable(projects, status);
   const fromRelease = project =>
     prerelease && latest[project].prerelease.hash
       ? latest[project].prerelease.hash
@@ -136,10 +137,11 @@ function getTemplates(individual) {
   }));
 }
 
-function createTable(projects) {
+function createTable(projects, status) {
   return `${projects.reduce(
     (table, project) =>
-      `${table}\n| ${project.name} | ${project.packageJSON.version} |`,
+      `${table}\n| \`${project.name}\` | \`${status[project.name]
+        .newVersion}\` |`,
     '| Package | Version |\n|---------|---------|',
   )}\n\n`;
 }