AptDpkgManager updated? returns true, even if package is not installed

[annaborn]

Hello!
I used AptDpkgManager to check the installed version of deb package.

package_manager = Autoproj::PackageManagers::AptDpkgManager::new(ws)
odb_installed = package_manager.installed?("odb")
deb_version = Autoproj::PackageManagers::DebianVersion::new("2.4.0-10")
check_version = package_manager.updated?("odb", deb_version)

If no odb package is installed, installed?("odb") will return false, as expacted. However, the updated?("odb", deb_version) will return true. Is it not confusing?
As suggestion: it would be great to use updated? on its own. At the moment, it is not possible, since updated? does not parse dpkg status file, how it was done in installed?.

[g-arjones]

Is it not confusing?

Although these APIs are considered private (we assume one won't check whether an uninstalled is updated) I agree it is confusing.

At the moment, it is not possible, since updated? does not parse dpkg status file

That's because the greatest available version AFAIK, can't be parsed from the status file. We use apt-cache for that and since that's a costly operation we don't do that in the updated? method.

That said, I think this class could use a great deal of refactoring and both issues could probably be addressed.