Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frodo CLI exits with code 0 in the case that an error occurs when calling the underlying FR API. #214

Closed
zya opened this issue Mar 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@zya
Copy link

zya commented Mar 13, 2023

Frodo CLI version

0.23.0

Describe the issue

Frodo CLI exits with code 0 in the case that an error occurs when calling the underlying FR API.
For example, if the application config file contain invalid configuration, and FR returns a 400.
This might be because of the way errors are handled in calls to FR here.
The errors are caught and logged but not returned again.

@zya zya added the bug Something isn't working label Mar 13, 2023
@vscheuber
Copy link
Contributor

@zya thank you for this report! Yes, we are painfully aware of this situation. We have started to introduce -1 return codes for commands we recently modified but it is not consistent, yet, and there is still a lot to do.

I'll definitely work on this but also welcome any help you are willing to render. If you are a developer and would like to help: please put up a PR :)

@vscheuber vscheuber self-assigned this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants