-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix UI Element text Breaking into two lines when long username #46
Comments
@Nabhag8848 I did not get this |
I mean |
@Nabhag8848 , I feel the issue lies here Using getCreator of IModify, full line text can be done, then using createContextBlock that is custom function defined, it can be done. |
Hey, I believe @brf153 is working on this issue. + please please please only work on one issue at a time. |
@Nabhag8848 , Certainly, sir. I apologize if it caused any inconvenience. Well, which issue should I work on, sir? Apart from preserving the message one, as that is a significant issue and requires a lot of discussion to fully understand the implementation. Currently, I am looking for a good first issue to understand the codebase and how RC apps work. |
@Nabhag8848 I believe there is an issue. For testing purposes, I created a function named sendNotificationWithBlock. Initially, you can observe that I have commented out some code, and I'm not using any blocks at this point. As shown in the picture below, the text is fully visible and does not break. When I remove the comment (i.e., when I add the block), I only get the block and not the message. The section block, which we were using earlier, does not allow us to increase the width, causing the text to break. We have two options: either replace the text with something else like |
yep. new uikit sets either text or block at a time. |
Oki I will check it |
@Nabhag8848 I have implemented the functionality you stated above. I am sending the action block as an attachment. Although the UI might not be perfect, it is working fine. |
Shall I raise a pr for these changes? |
Can we make a button variant to primary so we can have a blue background.+ change text to |
@Nabhag8848 I have made the changes for onInstall. It looks like |
Can we have that greeting on the second message ? also as we see, having two notification on install, can we make it one somehow and match the UI ? Can we have that layout as attachment and look as if it is attached below the notification with setup information like |
Shall I make these the same as I have done for the |
I can make something like |
@brf153 This Looks Good ! |
@brf153 having button as attachment would break this buttons variation and will force us to change that to grey (not primary) which we can avoid, as mentioned earlier. |
@brf153 Lets just have |
@Nabhag8848 what I understood is Do I need to make any further changes? |
looks good. Good to go for making changes to PR🚀 |
What happened?
onInstallation
message and when running/notion connect
text in notification is breaking into two lines. we need to make an notification such that it appears in single line even though username is large.Incase of
onInstallation
message we need to attach the layout to top the the Heyusername
welcome to notion app message below the layout.Steps to reproduce
/notion connect
with large username.Relevant ScreenShots
Screen.Recording.2024-01-29.at.00.25.37.mov
Version
v6.5
What browsers are you seeing the problem on?
Chrome
The text was updated successfully, but these errors were encountered: