Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

Suggest official Go SDK over third-party one #159

Closed
2 tasks done
OscarVanL opened this issue Feb 17, 2023 · 1 comment
Closed
2 tasks done

Suggest official Go SDK over third-party one #159

OscarVanL opened this issue Feb 17, 2023 · 1 comment

Comments

@OscarVanL
Copy link

Prerequisites

Please answer the following questions before opening an issue.

  • I checked to make sure that this issue has not already been filed
  • This issue concerns the developer's docs

Existing Docs

This page listing rocketchat REST APIs: https://developer.rocket.chat/reference/api/rest-api

Expected Behavior

The docs should link to Rocketchat's official Go library: https://github.com/RocketChat/Rocket.Chat.Go.SDK

Current Behavior

The docs link to a third-party golang rocketchat library: https://github.com/badkaktus/gorocket

I tried this library out and it is not great, for example, it discards all REST API response error bodies and status codes, and the omission of Success: true is the only indication you have that the API call failed. Finding out why the API call failed (using status codes or the error response body) is impossible.

I think it would be better to link to the official Go library.

@OscarVanL
Copy link
Author

OscarVanL commented Feb 17, 2023

Nevermind, the rocketchat-made one is probably buggier than the third-party one 😬

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant