Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading state to File upload modal #521

Closed
sidmohanty11 opened this issue Mar 17, 2024 · 6 comments · Fixed by #524
Closed

Add loading state to File upload modal #521

sidmohanty11 opened this issue Mar 17, 2024 · 6 comments · Fixed by #524
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sidmohanty11
Copy link
Collaborator

Screenshot 2024-03-17 at 5 38 08 PM
@sidmohanty11 sidmohanty11 added enhancement New feature or request good first issue Good for newcomers labels Mar 17, 2024
@JeffreytheCoder
Copy link
Contributor

JeffreytheCoder commented Mar 17, 2024 •
edited
Loading

Hey @sidmohanty11 I'd like to take on this issue - could you describe the expected behavior?

@sidmohanty11
Copy link
Collaborator Author

@JeffreytheCoder when we click "Send" it should show a loading spinner or Sending... with the button disabled

@JeffreytheCoder
Copy link
Contributor

@JeffreytheCoder when we click "Send" it should show a loading spinner or Sending... with the button disabled

gotcha! working on it

@ayush1108g
Copy link

ayush1108g commented Mar 18, 2024 •
edited
Loading

I am getting this error how to fix it?
image

@Spiral-Memory
Copy link
Contributor

Spiral-Memory commented Mar 18, 2024 •
edited
Loading

I am getting this error how to fix it? image

I think it's not the right place to ask, Please join https://open.rocket.chat/channel/embeddedchat and let's discuss there.
Anyway, for your problem, after cloning the repo, in root directory run yarn and yarn build. It will fix the issue ig.

@thesynthax thesynthax mentioned this issue Mar 19, 2024
Merged
@thesynthax
Copy link
Contributor

Hi @sidmohanty11, just added a PR fixing this issue. Please check out #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feat/fix] Added sending state to file upload modal thesynthax/EmbeddedChat
5 participants
@thesynthax @JeffreytheCoder @sidmohanty11 @Spiral-Memory @ayush1108g