Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Starred & Pinned messages sidebars fetch APIs infinitely #531

Closed
JeffreytheCoder opened this issue Mar 23, 2024 · 2 comments · Fixed by #532
Closed

[BUG] Starred & Pinned messages sidebars fetch APIs infinitely #531

JeffreytheCoder opened this issue Mar 23, 2024 · 2 comments · Fixed by #532
Labels
bug Something isn't working

Comments

@JeffreytheCoder
Copy link
Contributor

JeffreytheCoder commented Mar 23, 2024

Description:

Starred & Pinned messages sidebars fetch APIs infinitely, caused by a recent change in #525

Screenshot 2024-03-22 at 11 57 28 PM Screenshot 2024-03-22 at 11 57 49 PM

Steps to reproduce:

  1. Open starred or pinned message sidebar
  2. See the infinite calls in the "Network" tab of the inspection tool

Actual behavior:

sidebar-rerender

Expected behavior:

Only fetch API once when the sidebar is opened

@Spiral-Memory
Copy link
Contributor

Spiral-Memory commented Mar 23, 2024

Yep @JeffreytheCoder I'm aware of it i checked last night... are you fixing it, or should I, do it?
The thing is i wanted to make this realtime, so while the sidebar is opened, it should still fetch the pinned message as soon it happened, i'm looking for a way to achieve it without making infinite calls.

Edit: You already fixed it !, Thanks @JeffreytheCoder , but is there a way we can make this realtime ?

@Spiral-Memory
Copy link
Contributor

Spiral-Memory commented Mar 23, 2024

Maybe listening to Real-time Apis provided by RC for threads, pinned message and starred message using webhooks provided by RC SDK? Will it be possible ? @JeffreytheCoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants