Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Attachments sometimes fail to render on initial loads. #533

Open
Spiral-Memory opened this issue Mar 23, 2024 · 12 comments
Open

[BUG] Attachments sometimes fail to render on initial loads. #533

Spiral-Memory opened this issue Mar 23, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@Spiral-Memory
Copy link
Contributor

Description:

Attachments don't render properly on the first deployment without visiting the RC app first.

Steps to reproduce:

  1. Deploy Embedded Chat.
  2. Immediately send multiple different attachments such as photos/videos, etc.
  3. Notice that they won't render properly.

Expected behavior:

Attachments should render properly.

Actual behavior:

Attachments render only when you first visit Rocket Chat and then refresh the EC app.

Note: I'm unsure whether this issue is related to Embedded Chat or Rocket Chat. Also, the issue is hard to reproduce, so not attaching a video.

@Spiral-Memory Spiral-Memory added the bug Something isn't working label Mar 23, 2024
@JeffreytheCoder
Copy link
Contributor

@Spiral-Memory Great find! I had this issue for a long time...any idea why the files won't render?

@Spiral-Memory
Copy link
Contributor Author

Nope.. but if you just open rc once and refresh ec. It will start to render..

Why it happens is unknown !

@JeffreytheCoder
Copy link
Contributor

JeffreytheCoder commented Mar 24, 2024

Nope.. but if you just open rc once and refresh ec. It will start to render..

Why it happens is unknown !

I did this but it still doesn't render on my side...could you share a screen recording?

@Spiral-Memory
Copy link
Contributor Author

Sometimes, that happens too 😂 but it mostly works..

@Spiral-Memory
Copy link
Contributor Author

The exact cause is unknown !

@JeffreytheCoder
Copy link
Contributor

I found out the issue - I disabled the Settings -> File Upload -> Protect Uploaded Files and the files render perfectly :)

file-not-rendered

I'm updating the Readme so that EC contributors are aware of this

@Spiral-Memory
Copy link
Contributor Author

Spiral-Memory commented Mar 24, 2024

Hey, but why ? Why will i disable the option to protect uploaded files ?

Let's not keep it in readme.. it's a vague solution with no explanation involved. also the issue happens even if we login with admin account on EC. Let's keep the solution here to keep track.

@JeffreytheCoder
Copy link
Contributor

Check out this existing issue in RC-Electron.

Basically, the download link is opened in the default browser, not in the RC client (EC in our case). This is why in your case, you must log into RC in the browser before being authenticated to see the files.

Looks like this is an unsolved issue since 2016...so disabling the file protection option is a workaround for now

@Spiral-Memory
Copy link
Contributor Author

Great find, in my opinion, let's keep this issue and solution here.. or maybe I'll ask to include it in the FAQ.. Keeping it in readme won't be good in my opinion !

@JeffreytheCoder
Copy link
Contributor

well it's better to let more people know about this issue and the workaround...putting this on the FAQ is a good idea

@Spiral-Memory
Copy link
Contributor Author

Awesome !

@sidmohanty11
Copy link
Collaborator

Good find @JeffreytheCoder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants