Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It shouldn't print all the rows and columns as default #2

Closed
vikram-rawat opened this issue Oct 30, 2018 · 9 comments
Closed

It shouldn't print all the rows and columns as default #2

vikram-rawat opened this issue Oct 30, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@vikram-rawat
Copy link

Default should print only as much as console.

image

@rocketlaunchr-cto rocketlaunchr-cto added the enhancement New feature or request label Nov 1, 2018
@rocketlaunchr-cto
Copy link
Contributor

I'll eventually fix it up so it displays the first 3 and last 3 rows.
Alternatively, you can provide a PR and replicate the String() function in the Series structs.

@vikram-rawat
Copy link
Author

I am not a programmer and I am just learning Golang but I will try to help you out if possible. If there is something easy you want me to do I will surely do it.

I think this library needs

  1. Import from SQL
  2. Import from excel
  3. select columns
  4. Filter Rows
  5. Group By Values
  6. Basic functions like sum, mean etc....

Let me know if I can help in any of these. Best of Luck!!!

@rocketlaunchr-cto
Copy link
Contributor

rocketlaunchr-cto commented Nov 3, 2018

1. 2. I won't have time to implement import from SQL or Excel any time soon. That will require assistance from others.

3. What do you mean Select columns?
The function NameToColumn(seriesName string) combined with the Series field can be used to select columns.

4. 5. These I will work on when I figure out the best API to do so.

6. This is doable.

@rocketlaunchr-cto rocketlaunchr-cto mentioned this issue Nov 3, 2018
@bk521234
Copy link

I think this library needs

  1. Import from SQL
  2. Import from excel
  3. select columns
  4. Filter Rows
  5. Group By Values
  6. Basic functions like sum, mean etc....

I think these sounds like great ideas!

1. and 2. could be part of a longer term project road map.
4., 5., and 6. sound like great shorter term features to tackle.

can I help out anywhere @rocketlaunchr-cto ? we will have to break up large goals into manageable pieces..

@rocketlaunchr-cto
Copy link
Contributor

@bk521234 How would you like to help. I can write up a document on what you can do.

@bk521234
Copy link

i'd be willing to chip in some help to add a few features. a document could be really useful. maybe a wiki page with stuff? or small-ish projects for the near term?

I think the more functionality the package has, the more willing people will be to adopt/ use it

@vikram-rawat
Copy link
Author

vikram-rawat commented Dec 2, 2018

I am not a good programmer but I can help too. But If I get stuck somewhere I would want you to help me too... Start a slack channel or something where we could work.

@rocketlaunchr-cto
Copy link
Contributor

@vikram-rawat @bk521234 Here are some tasks:

  1. For func (df *DataFrame) NRows() int, insert an optional bool parameter so enable/disable the read lock inside the function. The default should be to read lock.

  2. Fix up the func (df *DataFrame) String() string { function found in dataframe_fmt.go to show only the first 3 items, then ..., then the last 3 items, similar to how the Series.String() function behaves.

They are easy changes.

@rocketlaunchr-cto
Copy link
Contributor

This has now been fixed. Print will only show max 6 rows as summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants