Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rocket.Unturned reference Rocket.Core and Rocket.API directly instead of nuget package #55

Closed
sunnamed434 opened this issue May 11, 2024 · 4 comments · Fixed by #60
Closed

Rocket.Unturned reference Rocket.Core and Rocket.API directly instead of nuget package #55

sunnamed434 opened this issue May 11, 2024 · 4 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@sunnamed434
Copy link
Member

https://github.com/RocketModFix/RocketModFix/blob/master/Rocket.Unturned/Rocket.Unturned.csproj#L11-L12
@sunnamed434 sunnamed434 added the enhancement New feature or request label May 11, 2024
@Jdance-Media
Copy link
Collaborator

We would have to wait for the Core and/or API package to update before working on features in the Unturned project that rely on changes to the Core and/or API.

@sunnamed434
Copy link
Member Author

Yep, you're right

sunnamed434 added a commit that referenced this issue May 12, 2024
@sunnamed434
Reference Rocket. Core/API directly, instead of NuGet Packages (#55)
cd79d80
@sunnamed434 sunnamed434 linked a pull request May 12, 2024 that will close this issue
Reference Rocket. Core/API directly, instead of NuGet Packages (#55) #60
Merged
@Jdance-Media
Copy link
Collaborator

I oppose the PR, as it would interfere with multi-project edits.

@sunnamed434
Copy link
Member Author

If you don't reference the .csproj inside of the .sln (solution) it doesn't allow you to reference the .csproj, however, maybe I was doing smth wrong

sunnamed434 added a commit that referenced this issue May 20, 2024
@sunnamed434
Merge pull request #60 from RocketModFix/reference-rocket-directly
5f2f3c6 
Reference Rocket. Core/API directly, instead of NuGet Packages (#55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference Rocket. Core/API directly, instead of NuGet Packages (#55) RocketModFix/RocketModFix
2 participants
@sunnamed434 @Jdance-Media