Getting Started Notebook Fails

[giovaniceotto]

Describe the bug

When running the getting started notebook (which can be done via Colab), it fails and throws and error in the Dynamic Stability Analysis section.

The error happens because a typo was fixed in every file of the master branch, including in the notebook (#106). The typo in question was the incorrect spelling "Costum" instead of "Custom", which affects the "CustomAtmosphere" argument that can be used in the Environment.setAtmosphericModel method. However, the current version of rocketpy released on PYPI (0.9.8) does not yet incorporate this typo fix.

To Reproduce

1. Access the Getting Started notebook via Google Colab
2. Run the entire notebook (all the cells, in order)
3. Notice ValueError: Unknown model type after running the Dynamic Stability Analysis cell

Expected behavior

The entire notebook should run without errors.

Screenshots

Solution Sugestion

Release a new version!

[Gui-FernandesBR]

Tks for sharing this!

Version Release will be adressed as soon as possible, I'll handle it myself.

[Gui-FernandesBR]

Hey, sorry for the failure on the asap part.
Still, I'd like to handle it myself anyway, I need to learn how to use the automatic release on PyPI package.
I'm creating here a deadline of 5days, so until 09th january this may be released.

@giovaniceotto can you help me to understand if we need to merge anything from "develop" do "master" before realeasing the new version? If positive, let's select the pull request and create the merge.

[giovaniceotto]

@Gui-FernandesBR, I do believe we may have a couple of things in the develop branch that could be merged into master before the new version. Could we discuss it further over discord, together with the automatic release?

[Gui-FernandesBR]

Great idea Gio! I will propose an appointment on your agenda for tomorrow and then we meet on discord

[Gui-FernandesBR]

Last release was created on 16th August. Since that day, the following PR were merged on develop branch:

• ENH: Roll moment calculation due to fin cant angle #116 - Roll moment Calculation added
• Enh/parachute #108 - Simple typos
• BUG: Fix .eng file comments #105 - Fixed .eng file bug;
  I'm proposing pulling these PRs into marge branch before launching the release on 8th January. The first one gives me a litte question: Should we wait before more users test the functino or should we go and already implement it on master version of RocketPy? The 2nd and 3rd are really simple so I think it is easy to make the decision.

@MrGribel could you please check and validate the proposal giving your OK (or NOK) for each line?
We need this before proceeding with the process of merging develop into master

[MrGribel]

Master branch should contain stable code. I doubt we have many users extensively testing our dev branch since it is not the default one, meaning we ourselves need to check if it is ready to deploy. Everything seems to be running well on my end and imo these PRs are too unrelated to have broken anything hidden due to conflict.

Just a thing: develop currently has a CI build error that should probably be adressed first. After that, feel free to merge and create a new release.

EDIT: Just noticed that since this is our first time merging from dev: it is 74 commits behind master...
It might require some care if any merge conflicts arise. Perhaps a temp staging branch could be a good idea to test everything beforehand.

[Gui-FernandesBR]

Works fine now, tks to all team!