Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement method to add rail buttons to a rocket #26

Closed
giovaniceotto opened this issue Feb 9, 2019 · 2 comments
Closed

Implement method to add rail buttons to a rocket #26

giovaniceotto opened this issue Feb 9, 2019 · 2 comments
Assignees
Labels
Enhancement New feature or request, including adjustments in current codes

Comments

@giovaniceotto
Copy link
Member

Currently, the Rocket class has no support for rail button characteristic input.

With the Rail Buttons Simulation Milestone in mind, a method such as Rocket.addRailButtons should be implemented allowing the user to define the axial and tangential position of two rail buttons used in the rocket.

@giovaniceotto giovaniceotto added the Enhancement New feature or request, including adjustments in current codes label Feb 9, 2019
@giovaniceotto giovaniceotto added this to the Rail Buttons Simulation milestone Feb 9, 2019
@giovaniceotto giovaniceotto self-assigned this Feb 9, 2019
@giovaniceotto
Copy link
Member Author

I will start working on this issue and the milestone in general in the rail_buttons branch.

@giovaniceotto
Copy link
Member Author

This has been implemented in the last commit.

Just to clarify, only the option to add 2 rail buttons, or a rail button pair, was considered. The reason behind this is that in terms of flight dynamics, only the last two rail buttons of a rocket matter. When more than two rail buttons are guiding the rocket, the situation is indeterminate.

Therefore, since the method wasn't really adding rail buttons but only setting the position of the rail buttons in terms of axial and tangential coordinates, the method was named Rocket.setRailButtons().

I will be marking this issue as closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
None yet
Development

No branches or pull requests

1 participant