Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocks dump escape xml tag #9

Open
lclementi opened this issue Sep 18, 2014 · 0 comments
Open

rocks dump escape xml tag #9

lclementi opened this issue Sep 18, 2014 · 0 comments
Assignees

Comments

@lclementi
Copy link
Contributor

rocks dump does too much escaping with attributes:

rocks set host attr compute-0-0-0 attr=cpu_match value="host-passthrough: <topology sockets='2' cores='8' threads='1'/><numa><cell cpus='0-7' memory='29360128'/><cell cpus='8-15' memory='29360128'/></numa>"

rocks list host attr compute-0-0-0 | grep cpu_match
    compute-0-0-0: cpu_match                         host-passthrough: <topology sockets='2' cores='8' threads='1'/><numa><cell cpus='0-7' memory='29360128'/><cell cpus='8-15' memory='29360128'/></numa>    

rocks dump host attr compute-0-0-0
/opt/rocks/bin/rocks add host attr compute-0-0-0 cpu_match host-passthrough:\ \<topology\ sockets=\'2\'\ cores=\'8\'\ threads=\'1\'/\>\<numa\>\<cell\ cpus=\'0-7\'\ memory=\'29360128\'/\>\<cell\ cpus=\'8-15\'\ memory=\'29360128\'/\>\</numa\>

rocks dump should use the parameter and the double quote e.g.:
value="aldkfkjdfk"

This should also be updated in the KVM users guide which report a bad example for the XML attribute.

Clem

@tcooper

@lclementi lclementi self-assigned this Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant