Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications! #66

Open
SpeedyCraftah opened this issue Mar 29, 2024 · 4 comments
Open

Notifications! #66

SpeedyCraftah opened this issue Mar 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@SpeedyCraftah
Copy link

SpeedyCraftah commented Mar 29, 2024

Would be great if you could configure it so that you received notifications about the current, and upcoming weather like Window's MSN weather app.
I'd be happy to submit a PR for this when I have some spare time, although I'm not sure about adding an entry for it in the settings since I've never worked with UI in C# for Windows, but I can probably figure it out.
It would also likely have to run in the background in the task bar, or at least a minimal separate process so that it can actually pull updates and display them in notifications.

@rocksdanister
Copy link
Owner

I am not sure what is notification, can you show a screenshot?

@rocksdanister rocksdanister added the enhancement New feature or request label Mar 31, 2024
@SpeedyCraftah
Copy link
Author

I am not sure what is notification, can you show a screenshot?

I mean the Windows notifications! Here is how they look from the Microsoft weather app:
image

@rocksdanister
Copy link
Owner

rocksdanister commented Apr 9, 2024

Ah I see.

One issue I see is that currently the cache and weather fetch code is run from the main app, for background notification there needs to be background service and it will probably need to run it #3

@SpeedyCraftah
Copy link
Author

SpeedyCraftah commented Apr 9, 2024

Ah I see.

One issue I see is that currently the cache and weather fetch code is run from the main app, for background notification there needs to be background service and it will probably need to run it #3

That shouldn't be an issue, there's many ways we could do this. We could have a separate program running that starts on windows startup (should user allow it) which will run in background and update the weather cache as well as giving upcoming weather notifications, or we could make a service but don't know if services can send notifications. Either way we should keep it as simple as possible.

We could probably also keep it in the main program, but add an option to hide or show the UI which should also free up resources associated with it. The periodic weather updates and notifications can run on a separate thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants