Loads of warnings if locale en_US is not installed

[bassjoe]

If the script must depend on the locale en_US.UTF-8 (#67?) it should make sure it is installed.

If it is not present, the output is full of warnings(?) starting with file not found for line 108. While the system seems to operate normally after reboot, these messages don't promote trust in the result.

Not knowing what's the purpose of setting the locale I can't provide a fix.

Big THANKS for Rocky Linux!

sudo ./migrate2rocky.sh -r
./migrate2rocky.sh: Zeile 108: Warnung: setlocale: LC_ALL: Kann die Locale nicht ändern (en_US.UTF-8): Datei oder Verzeichnis nicht gefunden
./migrate2rocky.sh: Zeile 108: Warnung: setlocale: LC_ALL: Kann die Locale nicht ändern (en_US.UTF-8).

Removing dnf cache
Preparing to migrate CentOS Linux 8 to Rocky Linux 8.

Determining repository names for CentOS Linux 8.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8


Found the following repositories which map from CentOS Linux 8 to Rocky Linux 8:
CentOS Linux 8  Rocky Linux 8
appstream       appstream
baseos          baseos
extras          extras

Getting system package names for CentOS Linux 8Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8
.Failed to set locale, defaulting to C.UTF-8

... and so on

[pajamian]

A bad assumption was that en_US would be on every machine, even if it was not the primary locale.
I think that C.UTF-8 would work better, should be on every el8 system and should not cause heaps of warnings like the above.

[suchagoodguy]

dnf install -y glibc-langpack-en fixes that

[pajamian]

Can you test with this version, please?
https://github.com/pajamian/rocky-tools/blob/C_locale/migrate2rocky/migrate2rocky.sh

[bassjoe]

Looks good with this version, the warnings are gone.

[pajamian]

Pulled with #98