Broken "list ." command #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes look good - thanks! However the CI tests fail. In commit bc94ea4 I have addressed appveyor failure. As for the other failure, I think all adjusting listsize in https://github.com/rocky/python3-trepan/blob/master/test/unit/test-list.py#L13 and/or the computations using that, eg. line 56 is needed. python3-trepan/test/unit/test-list.py can be run from python on its own to check for other things that need to be changed. If you'd do that we could merge this in without causing CI breakage. Thanks, again. |
|
Hi Rocky,
I think the listsize is ok, I tried several values and all values > 1
pass all tests (as in 'python3 test-list.py'). Maybe I am not running
the same test as you are?
Cheers,
Giuseppe
…----- Original Message -----
From: "rocky/python3-trepan"
To:"rocky/python3-trepan"
Cc:"Giuseppe Scelsi" , "Author"
Sent:Thu, 27 Sep 2018 02:24:28 -0700
Subject:Re: [rocky/python3-trepan] Broken "list ." command (#19)
The changes look good - thanks! However the CI tests fail. In commit
bc94ea4 [1] I have addressed appveyor failure. As for the CircleCI
test. As for the other failure, I think all that is needed is to
adjust listsize in
https://github.com/rocky/python3-trepan/blob/master/test/unit/test-list.py#L13
[2].
If you'd do that we could merge this in without causing CI breakage.
Thanks, again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [3], or mute the
thread [4].
Links:
------
[1]
bc94ea4
[2]
https://github.com/rocky/python3-trepan/blob/master/test/unit/test-list.py#L13
[3]
#19 (comment)
[4]
https://github.com/notifications/unsubscribe-auth/AbhOj-Yk4P_Ma8p1oS4ni2Is2Ks_nzfjks5ufJlMgaJpZM4W78Sp
|
|
Hold on, please ignore my previous message, I just found there is more to it. Will be back soon. |
|
https://travis-ci.org/rocky/python3-trepan/jobs/433918855#L611 is about changing the listsize value in the test. |
rocky
force-pushed
the
master
branch
2 times, most recently
from
bc3cc15
to
533c92b
Compare
rocky
force-pushed
the
master
branch
3 times, most recently
from
fbdaf79
to
894bdef
Compare
rocky
force-pushed
the
master
branch
4 times, most recently
from
b2fd9e7
to
c3e9813
Compare
rocky
force-pushed
the
master
branch
4 times, most recently
from
e550808
to
4f43a01
Compare
rocky
force-pushed
the
master
branch
4 times, most recently
from
563695f
to
3e8646d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dd81b32 is a simple modification that fixes the behaviour of "list .".
While I was at it, with dd81b32 I also fixed the number of lines printed as a result of commands such as "list 25," and similar. According to my understanding the number of lines printed when one of the range limits is left blank should always be "listsize" (10 by default), while in many cases the number was actually 11.