-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3.X][CUDA >= 11.0] hipblasGemmEx
doesn't fully match cublasGemmEx
#529
Comments
emankov
changed the title
[5.2.X]
[5.2.X][CUDA >= 11.0] Sep 24, 2022
hipblasGemmEx
doesn't fully match cublasGemmEx
hipblasGemmEx
doesn't fully match cublasGemmEx
The same goes to: |
emankov
added a commit
to emankov/HIPIFY
that referenced
this issue
Sep 24, 2022
+ Added tests for the following BLAS functions: DGMM, GemmEx, GemmBatchedEx, GemmStridedBatchedEx + Gem(Batched|StridedBatched)Ex have two different signatures (before CUDA 11.0 and after CUDA 10.2) + [Workaround][ROCm/hipBLAS#529]: `cublasComputeType_t` -> `hipblasDatatype_t` (instead of yet unsupported `hipblasComputeType_t`) + Regenerate and update hipify-perl and docs
Hi @emankov, Thanks for bringing this up. We will likely make a change to include a similar compute_type in the hipblasGemm*Ex interfaces in a future release. I will keep you updated with any progress. Thanks, |
emankov
changed the title
[5.2.X][CUDA >= 11.0]
[5.3.X][CUDA >= 11.0] Nov 7, 2022
hipblasGemmEx
doesn't fully match cublasGemmEx
hipblasGemmEx
doesn't fully match cublasGemmEx
emankov
added a commit
to emankov/HIPIFY
that referenced
this issue
Oct 14, 2023
… - `hipblasDatatype_t` -> `hipblasComputeType_t` [IMP] + In hipBLAS 6.0.0, ROCm/hipBLAS#529 is finally fixed, thus HIPIFY can use `hipblasComputeType_t` instead of `hipblasDatatype_t`, where `cublasComputeType_t` is implied [TODO] + Revise all the hipBLAS functions which use `hipblasDatatype_t` instead of `hipblasComputeType_t` + Close ROCm/hipBLAS/issues/529 as implemented with the releasing of hipBLAS 6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem is with the penultimate argument
hipblasDatatype_t computeType
, which doesn't match tocublasComputeType_t computeType
.cublasComputeType_t
appeared with CUDA 11.0.cublasGemmEx
usedcudaDataType
instead ofcublasComputeType_t
for its penultimate argument starting with CUDA 8.0 and till CUDA 11.0.The text was updated successfully, but these errors were encountered: