You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
User should have control of whether they want to build for either platform, since you can't do both at once
What actually happens
You have no way to specify that the build is meant for HCC, if you have CUDA at all installed, for whatever reason, it tries to enable that, and if you were trying to build with HCC, the build fails
How to reproduce
Try to build using HCC, for ROC, but also have CUDA installed on your system
Environment
Observed in Arch Linux whilst converting the scripts from Experimental ROC
I have CUDA installed and bumped into this.
Proposed fix
I'm making a PR with what seems to be the simplest way to do this, I provided an additional TRY_CUDA option. if that is OFF, the find_package call is skipped. By default it is ON, so the legacy behaviour is maintained.
But really I feel like making this choice on the back of a find_package (and a find module that has already been deprecated anyway) is the wrong way to do this. Instead the correct would be a bit of a larger change and would include
set(HIPBLAS_BACKEND "hcc"CACHE STRING "Backend the hipBLAS build should use")
set_property(CACHE HIPBLAS_BACKEND PROPERTYSTRINGS"hcc;cuda")
And then derive all the choices in inner branches of the build tree from querying this variable
The text was updated successfully, but these errors were encountered:
VileLasagna
added a commit
to VileLasagna/hipBLAS
that referenced
this issue
Mar 3, 2019
What is the expected behavior
User should have control of whether they want to build for either platform, since you can't do both at once
What actually happens
You have no way to specify that the build is meant for HCC, if you have CUDA at all installed, for whatever reason, it tries to enable that, and if you were trying to build with HCC, the build fails
How to reproduce
Try to build using HCC, for ROC, but also have CUDA installed on your system
Environment
Observed in Arch Linux whilst converting the scripts from Experimental ROC
I have CUDA installed and bumped into this.
Proposed fix
I'm making a PR with what seems to be the simplest way to do this, I provided an additional
TRY_CUDA
option. if that isOFF
, the find_package call is skipped. By default it is ON, so the legacy behaviour is maintained.But really I feel like making this choice on the back of a find_package (and a find module that has already been deprecated anyway) is the wrong way to do this. Instead the correct would be a bit of a larger change and would include
And then derive all the choices in inner branches of the build tree from querying this variable
The text was updated successfully, but these errors were encountered: