Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop complaining about things unsupported versions of Puppet won't support. #281

Closed
jorhett opened this issue Jul 14, 2014 · 5 comments
Closed

Comments

@jorhett
Copy link

jorhett commented Jul 14, 2014

Puppet 2.6 is unsupported. Nobody cares what it won't accept any more. Please disable this nonsense, allowing it to be enabled by someone who cares about ancient versions.

At the very least, give us a single hammer for all of the unsupported versions rather than half a page of disable options. Really.

@Aethylred
Copy link

Puppet 2.6 is still the version installed distributions based on RedHat 6.5 (RedHat, CentOS, ScientificLinux etc.), when you're automating these distro's Puppet 2.6 is where you start.

@jorhett
Copy link
Author

jorhett commented Jul 15, 2014

There is no version of puppet on any of these operating systems. There is no version of puppet 2.6 in any of their common repositories, e.g. EPEL, and has not been for almost a year. I have no idea where you are proposing that people start, but it's clearly something only you know about.

Puppet 2.6 is dead. Time to stop complaining about an obsolete, unsupported product.

@rodjek
Copy link
Owner

rodjek commented Jul 30, 2014

@jorhett puppet-lint's mission is to try and enforce as much of the official style guide as possible. If you feel this strongly about a check, you should suggest your change to the style guide to Puppet Labs.

@rodjek rodjek closed this as completed Jul 30, 2014
@jorhett
Copy link
Author

jorhett commented Jul 30, 2014

I am talking about the Puppet style guide. It recommends params, which you complain about. As a matter of fact, lint currently complains about more things that the style guide recommends than it does that the style guide warns against.

As stated before, there is no support for Puppet 2.6. It's time for lint to stop complaining against 3.0 recommended practice in favor of a version with no support, and no visibility within any public repository. At very best, there should be an option for "--include-obsolete-warnings" to enable these complaints.

@rodjek
Copy link
Owner

rodjek commented Jul 30, 2014

It recommends params, which you complain about.

I assume you mean the check that complains when you inherit a modules params class?

From the style guide:

The following alternative method SHOULD NOT be used because it is not compatible with Puppet 2.6.2 and earlier.

It recommends including the params class, and explicitly recommends not inheriting it.

As a matter of fact, lint currently complains about more things that the style guide recommends than it does that the style guide warns against.

Can you provide examples of this? I'm happy to change the logic of the tests if I've misinterpreted the style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants