Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when identifying old Internet Explorer version #40

Closed
roopemerikukka opened this issue Jan 26, 2015 · 5 comments
Closed

Error when identifying old Internet Explorer version #40

roopemerikukka opened this issue Jan 26, 2015 · 5 comments

Comments

@roopemerikukka
Copy link

Hi,

I'm getting error when the test checks for old IE version:

/*@cc_on

  @if (@_jscript_version <= 10)
    isOldInternetExplorer = true;
  @end

@*/

The error I'm getting is: Unable to get property 'init' of undefined or null reference

This can be fixed by putting variable identifier in front of isOldInternetExplorer So the working check would be looking like this:

/*@cc_on

  @if (@_jscript_version <= 10)
    var isOldInternetExplorer = true;
  @end

@*/
@rodneyrehm
Copy link
Owner

weird. @zoltan-dulac has more insight into Internet Explorer's Conditional Comments… ping

@roopemerikukka
Copy link
Author

After giving more look for the code, I don't think this fixes any problems but only removes the error because the variable is indeed introduced before.

I'm having the error above with IE10 / Win7 and that also stops loading of all the scripts left.

@zoltan-dulac
Copy link
Contributor

@roopemerikukka Thanks so much for the bug report. Curious - I have never seen this bug before and can't replicate the issue ... I would love to know under what circumstances you are getting the original message. Can you give the following info?

  • What exact version of IE are you using (you mention IE10/Win 7, but I want to know if you have seen it in others)
  • Is the browser in compatability mode or standards mode? What are the exact settings?
  • Do you have a URL in which we can replicate the problem?

All of that info (especially the URL) will help me troubleshoot this.

@roopemerikukka
Copy link
Author

@zoltan-dulac I'm using Windows 7 and Internet Explorer 10.0.9200.16721. This setup is running in VirtualBox VM from https://www.modern.ie/en-us without any updates installed.

I cannot give the URL because the site we are developing is running in internal test server. I tried to create duplicate of the page but couldn't replicate the problem. Don't know if the problem is caused by combination of different js libs.

rodneyrehm added a commit that referenced this issue Jul 15, 2015
Use user agent sniffing to detect IE9 - #43, #40
@rodneyrehm
Copy link
Owner

should've been resolved since #43 landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants