Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

understand_cv documentation spelling updates #57

Merged
merged 2 commits into from Jul 1, 2021

Conversation

Turtle24
Copy link
Contributor

I updated the understand_cv documents grammar and spelling a bit. This is for #43 and I'll slowly go over all the documentation because I want to better understand the package and work on the inner workings eventually.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #57 (0163439) into master (123b1bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          720       720           
=========================================
  Hits           720       720           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123b1bd...0163439. Read the comment docs.

Copy link
Owner

@rodrigo-arenas rodrigo-arenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ey thanks! This is really useful, I see a lot of typos I missed and a better redaction.

I just have a comment on the change from "and search problems" to "and search of problems" in the line 25. I think it should remain the same.

What I want to tell, is that there is a subset of problems in optimization, that are called "search problems", see for example this page

Let me know what you think, and if you are agree, let's change that line before merging, thanks!

@Turtle24
Copy link
Contributor Author

Turtle24 commented Jul 1, 2021

Ey thanks! This is really useful, I see a lot of typos I missed and a better redaction.

I just have a comment on the change from "and search problems" to "and search of problems" in the line 25. I think it should remain the same.

What I want to tell, is that there is a subset of problems in optimization, that are called "search problems", see for example this page

Let me know what you think, and if you are agree, let's change that line before merging, thanks!

Ok awesome, I updated it. Yeah you're right, I missed the context so I get what you're saying 👍🏽

@rodrigo-arenas
Copy link
Owner

Great, this is looking good!
Thanks again

@rodrigo-arenas rodrigo-arenas merged commit 8df98b3 into rodrigo-arenas:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants