-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winsvc.h #99
Comments
Hi Tom,
Yes, I think it would be a nice addition to the library.
That's pretty much how
Seems like a good idea. I would be glad to help you with your fork, until it's stable enough to be merged into the master branch.
The Cargo features of My first attempt was very rigid about the Cargo features, with each item correctly placed according to its DLL. It was beautiful, a super organized library. But I quickly got a lot of headaches with the Windows API C headers. For example: the base of everything is kernel32; advapi32 is built on top of it. That said, let's dive onto your case. As far as I could see, the Dealing with stuff like this can be pretty overwhelming, so I suggest you to start simple. Start with the first function call you need, then perform a Cargo check in isolation:
The proceed to the next function, until something weird appears. And let me know of your progress, we can work together on this. |
Hello @rodrigocfd I sent a very preliminary PR here: #100 which is not ready to merge at all but thought it would be useful so you can view it a bit. After your helpful response and studying the Windows API more I see that the API's for working with Windows Services are similar to working with regular Windows. There is a lot of messaging and the messages are implemented in the The winsafe crate has a precedent for everything I needed to do so far, and so I tried my best to follow existing patterns. Let me know what you think and I'll finish adding the messaging types and service api's and comment again if stuck. |
This is more of discussion or feature request. But is there any interest in implementing the winsrv.h stuff like
StartServiceCtrlDispatcher
and associalted api's?I find I am trying to implement wrappers around the winsrv api's from windows crate and thought perhaps forking winsafe and implementing them in here. the winsrv api's use a lot of types in the winuser.h. So I'm guessing all the consts and structs could be added to the
user/co/consts
anduser/structs
types and maybe add a new feature folder forservice
apis inwinsrv.h
?is this correct way to go? Is this kind of PR welcome?
The text was updated successfully, but these errors were encountered: