Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the patient name field #52

Closed
laurasstephan opened this issue Apr 22, 2020 · 6 comments
Closed

Bug in the patient name field #52

laurasstephan opened this issue Apr 22, 2020 · 6 comments
Assignees
Labels
bug Something isn't working high priority
Projects

Comments

@laurasstephan
Copy link
Collaborator

I am testing as a patient in an old Android default browser ("Samsung internet"?).
In the Name field, it only allows me to proceed when I type a name (let's say "Teste") + space. If I do not add the space, it erases whatever I had typed and asks me for the Name again.
I've recorded a video of the bug, but it was too big to add here - ask me on Whatsapp.

@rodrigogs rodrigogs added this to To do in Project Apr 22, 2020
@rodrigogs rodrigogs moved this from To do to Planning in Project Apr 22, 2020
@rodrigogs rodrigogs self-assigned this Apr 22, 2020
@rodrigogs
Copy link
Owner

@laurasstephan I need more technical info about the browser version or at least the phone model and Android version

@laurasstephan
Copy link
Collaborator Author

Phone is SM-G920I and Android version 7.0
Browser is Samsung Internet 11.1.2.2

@rodrigogs
Copy link
Owner

Found this: vuejs/vue#9777

And it's a very concerning problem. I tried a lot and I couldn't figure a fix out.

@kuroski, would you take a look at this? I think I've exhausted my frontend skills in trying to fix it.

@rodrigogs rodrigogs added bug Something isn't working high priority and removed low priority labels Apr 25, 2020
@rodrigogs
Copy link
Owner

rodrigogs commented Apr 25, 2020

It shall impact a huge amount of users, so it's a high priority.

@kuroski kuroski assigned kuroski and unassigned rodrigogs Apr 25, 2020
@kuroski
Copy link
Collaborator

kuroski commented Apr 25, 2020

Unfortunately, I think there is nothing much we can do right now, this is a problem that happens with some Android devices because of the google keyboard.

There are more issues regarding this problem:
vuelidate/vuelidate#534

And there is a PR in the Vue repository to fix that:
vuejs/vue#9814

I've tried to use the suggestions from people on the issue and nothing worked:

  • Remove v-model and use :value/@input approach
  • Use @blur event
  • Use timeout

What happens is:

In some android devices because of the text suggestion of the google keyboard, it won't emit the "input event" until you select some suggestion or press the "space key"

=/

I'll continue trying to fix that, but I don't think we will have much to do.

@kuroski
Copy link
Collaborator

kuroski commented Apr 26, 2020

Finally, I think I've got it =DDD

First I've tried a different approach: https://github.com/kuroski/v-eager
I created this directive to fix the problem.

But then I checked again, and we don't have this problem on other screens that have forms.

Actually the problem was really simple.

We were setting the form variables as null instead of empty strings ''.

Please check the closing commit for more details

Project automation moved this from Planning to Done Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
Project
  
Done (merged)
Development

No branches or pull requests

3 participants