Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to android v2 embedding #17

Merged
merged 19 commits into from Sep 29, 2021
Merged

Migrate to android v2 embedding #17

merged 19 commits into from Sep 29, 2021

Conversation

nohli
Copy link

@nohli nohli commented Sep 17, 2021

There is a warning regarding the v2 migration during every flutter build, even just on pub get.

The other plugins were really quick with updates - this is (for me) the last plugin that hasn't been updated yet.
A new version on pub.dev would be great! :)

This PR fixes it.

@nohli nohli mentioned this pull request Sep 18, 2021
@sanekyy
Copy link

sanekyy commented Sep 18, 2021

Let's merge it!:)

@nohli
Copy link
Author

nohli commented Sep 18, 2021

Let's merge it!:)

@sanekyy @kakudenbuzo could you also test it on a real Android device before it gets merged/published?

@kakudenbuzo
Copy link

@nohli
On my android device, it worked!

@nohli
Copy link
Author

nohli commented Sep 20, 2021

@rodydavis Idk if you already saw this :)

@armandojimenez
Copy link

Any plans to merge this?? :D

@PhilipPurwoko
Copy link

Just to be clear, this is the exact warning message shown

The plugin `flutter_vibrate` uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.

This branch has no conflicts. Please merge soon 😄

@designedbyclu
Copy link

@rodydavis any plan to merge it soon?

@rodydavis rodydavis merged commit 9abea99 into rodydavis:master Sep 29, 2021
@rodydavis
Copy link
Owner

I will publish today

@rodydavis
Copy link
Owner

published 1.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants