Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected/Unselected icon color in tablet mode not consistent #4

Open
D-Jeremie opened this issue Feb 6, 2020 · 2 comments
Open

Selected/Unselected icon color in tablet mode not consistent #4

D-Jeremie opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@D-Jeremie
Copy link

D-Jeremie commented Feb 6, 2020

First of all, thank you for your great widget !

I just noticed that in Tablet mode the color of selected and unselected icons are not consistent with phone mode.
Maybe it's a feature that you choose ?

If not you could consider this :

Inside _buildTab you could easily make it consistent with final _color = selected ? bottomNavigationBarSelectedColor : bottomNavigationBarUnselectedColor;
instead of final _color = selected ? _isDark ? Colors.tealAccent[200] : _theme.primaryColor : Colors.grey;

@rodydavis
Copy link
Owner

Yep just saw this. I fixed it on my local copy. I will push a fix soon

@rodydavis
Copy link
Owner

Fixed on dev version: https://pub.dev/packages/navigation_rail/versions/1.6.0-dev.1

Can you test?

@rodydavis rodydavis added enhancement New feature or request question Further information is requested labels Apr 16, 2020
@rodydavis rodydavis self-assigned this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants