Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to sf2 file on README of flutter_midi #3

Closed
kaboc opened this issue Dec 7, 2019 · 7 comments
Closed

Broken link to sf2 file on README of flutter_midi #3

kaboc opened this issue Dec 7, 2019 · 7 comments

Comments

@kaboc
Copy link

kaboc commented Dec 7, 2019

The link to sound_font.SF2 on the README of flutter_midi leads to Google Drive which says the requested file is not found.
FYI just in case the issue has something to do with my location, I accessed it from Japan.

@rodydavis
Copy link
Owner

Yeah it might be that then. Any .sf2 file will work!

@kaboc
Copy link
Author

kaboc commented Jan 30, 2020

I found a nice .sf2 file, but other developers may feel at a loss.
How about correcting the link, or just removing it and adding an explanation like 'search for a sound font file by yourself'?

@rodydavis
Copy link
Owner

Will do, please feel free to make a PR if you found a open .sf2 file.

@kaboc
Copy link
Author

kaboc commented Jan 30, 2020

I used this file. Unfortunately, only notes between 0 - 127 were available (which was alright for me though) and the page is Japanese. I will make a PR if I find a better one.

@rodydavis
Copy link
Owner

Ok thank you! On the web im working on a version that uses Tone.js

@kaboc
Copy link
Author

kaboc commented Jan 31, 2020

Sounds nice! I used Tone.js for my piano app in a similar way as in your flutter_piano, but futter_midi with Tone.js integrated out of the box will make things easier. Thanks!

@rodydavis
Copy link
Owner

Now fixed on the latest version! And updated the example to use Tone.js in Flutter web!

@rodydavis rodydavis transferred this issue from rodydavis/plugins Jan 31, 2020
@kaboc kaboc closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants