Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload makes the Graph all blank #209

Open
Maryusz opened this issue Mar 5, 2024 · 6 comments
Open

Hot reload makes the Graph all blank #209

Maryusz opened this issue Mar 5, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Maryusz
Copy link

Maryusz commented Mar 5, 2024

While testing the capabilities of the library, when opening the DevTools on browser the Graph section works correctly.

Schermata del 2024-03-05 22-49-52

After the hot reload:
Schermata del 2024-03-05 22-52-41

The list page isn't affected

environment:
  sdk: '>=3.3.0 <4.0.0'

dependencies:
  build_runner: ^2.4.8
  flutter:
    sdk: flutter
  freezed: ^2.4.7
  freezed_annotation: ^2.4.1
  signals: ^4.5.1
  signals_flutter: ^4.5.1

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^3.0.0

flutter:
  uses-material-design: true

Other infos:
Browser: Brave
Os: Ubuntu Linux 23.10
Dart: 3.3.0
Flutter: 3.19.1

@rodydavis
Copy link
Owner

Thanks for the bug! This might be related:

#206

@rodydavis rodydavis added the bug Something isn't working label Mar 5, 2024
@rodydavis
Copy link
Owner

Should be fixed on the next release!

@PaulHalliday
Copy link
Contributor

PaulHalliday commented Apr 7, 2024

I still have this issue where the graph will be entirely grey, even from app launch with no hot reload. (Running on 5.0.0-beta12)

On a larger project that implements Signals, I've never had the graph (always greyed out), but, I can see the graph on a brand new project with a few test signals.

As a result, I don't specifically have a reproduction case, but I will note that my signals list in the devtools is populated with all my signals, however tapping on some of the tiles either gives me a list of signal targets, or the section is greyed out.

Not sure if this could be related/is helpful, but thought I'd chime in anyway.

@rodydavis rodydavis reopened this Apr 7, 2024
@rodydavis
Copy link
Owner

I pushed a new build with the latest beta, but would really like a minimal to test against so it can be added to tests.

@PaulHalliday
Copy link
Contributor

PaulHalliday commented Apr 14, 2024

Using the latest (5.0.0), my main project has reverted to stating No nodes created (despite using signals project-wide) with no graph.

There is an info log in the JavaScript console of devtools though:

Error fetching all signals: ext.signals.getAllNodes: (-32601) Unknown method "ext.signals.getAllNodes".

@rodydavis
Copy link
Owner

Got it, will see what is happening here. Working on making sure the dev tools is on the right version too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants