Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StoryBoard and DevicePreview play nice together - [device_preview] #10

Closed
rydmike opened this issue May 6, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@rydmike
Copy link

rydmike commented May 6, 2020

If you wrap your Material app in a DevicePreview (https://pub.dev/packages/device_preview) and then in a StoryBoard, the screens presented in the story board do not get the correct media size.

image

This happens also if the DevicePreview enabled property is set to false and StoryBoard is set true.

It would be great if DevicePreview and StoryBoard could play nicely together, at least when they are not enabled at the same time.

@rodydavis rodydavis added bug Something isn't working enhancement New feature or request labels May 6, 2020
@rodydavis rodydavis self-assigned this May 6, 2020
@rodydavis rodydavis added this to To do in v1 via automation May 6, 2020
@rodydavis
Copy link
Owner

Can you share a code snippet so i have the correct code to test with?

@rodydavis
Copy link
Owner

Experiments are being done here: https://github.com/rodydavis/storyboard/tree/device_preview

@rodydavis rodydavis changed the title Make StoryBoard and DevicePreview play nice together Make StoryBoard and DevicePreview play nice together - [device_preview] May 11, 2020
@rodydavis
Copy link
Owner

Added device frames on 0.1.5!

v1 automation moved this from To do to Done Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
v1
  
Done
Development

No branches or pull requests

2 participants