Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a problem in base_dataset.py #2

Closed
raven0327 opened this issue Dec 21, 2020 · 1 comment
Closed

a problem in base_dataset.py #2

raven0327 opened this issue Dec 21, 2020 · 1 comment

Comments

@raven0327
Copy link

from sg2im/data/base_dataset.py
ln89: def add_learnt_triplets(self, triplets, O):
triplets = np.unique(triplets, axis=0).astype('int')
new_triplets = []
N_REL = len(self.vocab['pred_name_to_idx'].values())
conv_counts = np.zeros((N_REL, N_REL + 1))
triplets = np.array(triplets)
i couldn't understand the meaning of variable 'O' , thanks for answering my question.

@roeiherz
Copy link
Owner

Hi,

Thanks for your comment!

It seems we used this variable in the past to represents the number of objects. However, it is not used in the method anymore, and thus you can ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants