Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here's a new batch of sites with problems #16

Closed
f1h0 opened this issue Apr 14, 2020 · 11 comments
Closed

Here's a new batch of sites with problems #16

f1h0 opened this issue Apr 14, 2020 · 11 comments

Comments

@f1h0
Copy link

f1h0 commented Apr 14, 2020

https://cp.beget.com
when I want to choose my account, it has a strange behavior.
the plugin works with other websites.

https://passport.yandex.com
on this site the selected entry via the plugin does not work

https://www.nic.ru/en/auth/login/
when I select an account and click login, the password is erased.

https://account.elama.global/
the ChromeKeePass plugin does not work on this site at all.

@f1h0
Copy link
Author

f1h0 commented Apr 14, 2020

I often use these sites with a lot of clients I help out with.

@RoelVB
Copy link
Owner

RoelVB commented Apr 14, 2020

Thanks.

Beget.com
It looks like this doesn't work when single clicking credentials. But when I double click or use enter it seems to work. Can you confirm this is the same for you?

Yandex
I don't know how to solve this. You have to press "Log in" twice. Before the first login the password field is there, but hidden. But is looks like after you press "log in" they create a new password field (which of course is then empty)
As a workaround when you get at the empty password field you could right click and choose "Redetect fields" under "ChromeKeePass". Then you should be able to enter the password.

NIC
Seems to work fine for me

eLama
Same method as for Yandex. Right click and choose redetect fields.

I'm thinking about a beter way to redetecting fields, but I'm not sure how I'm going to do that yet.

@f1h0
Copy link
Author

f1h0 commented Apr 15, 2020

that's what I noticed.
Beget.com
if you access the site via the home page https://beget.com.
I don't have a login field.
image

Yandex
here's what I do.
l6KiH

your references tried, they didn't work.

ChromeKeePass application is very good, and useful only there are sites where it works badly.

@BlaM
Copy link

BlaM commented Aug 4, 2020

On https://www.namecheap.com/ when I click somewhere on the page the "ChromeKeePass" layer appears in the top left corner.

@RoelVB
Copy link
Owner

RoelVB commented Aug 11, 2020

@BlaM Could you maybe post a screenshot? I don't have any issues there.

@BlaM
Copy link

BlaM commented Aug 11, 2020

Interesting - and yes, you may be right. This is what happens for me:

namecheap

BUT: If I do the same in incognito mode, nothing happens - so that might be an compatibility issue with another addon I use. I'll try to figure out which one it is and get back to you. Until then feel free to ignore my previous comment ;)

[Update 2020-08-13]
It doesn't seem to be another extension. The problem still occurs with all other Chrome extensions disabled and it also occurs on other pages. Is there a way to know which DOM node the popup "attached" to? Maybe a debug option that adds a data-attribute to the DOM node could help, just to simplify locating the related element?

@RoelVB
Copy link
Owner

RoelVB commented Sep 3, 2020

@BlaM
Could you try this:

  1. When on the site
  2. Open the DevTools (F12)
  3. Goto the console and execute the command $('input[type="password"]')

What's the result? There should appear only one input.

@BlaM
Copy link

BlaM commented Sep 4, 2020

It returns the correct (single) password input field, but that <input> lies inside a hidden <div>.

Quick sidenote: namecheap does not use jQuery, so "$" is the version built in in Chrome - which will always return one element max. I injected jQuery into the page for this test, though.

jQuery('input[type="password"]') returns one password field, jQuery('input[type="password"]:visible') returns no results.

Other fun observation: I don't even have to click on the page to make the chromeKeePass layer appear. It will also appear if I type anything (valid or invalid, does not matter) into the dev console within the first 2 or 3 seconds after loading the page. If I wait longer, then nothing will happen. This is an extremely strange behaviour and I don't really have an explanation for it.

@RoelVB
Copy link
Owner

RoelVB commented Sep 4, 2020

@BlaM Thank you, this is useful information.

It pointed me to the issue. It turns out I do check if a username field is visible:
https://github.com/RoelVB/ChromeKeePass/blob/master/src/classes/PageControl.ts#L39-L41
But I don't check this for password fields. I'll try to find some time this weekend to change this.

It still doesn't make sense to me that the dropdown shows up for you, but I'm almost certain checking the visibility of the password field will fix this.

@RoelVB
Copy link
Owner

RoelVB commented Sep 7, 2020

@BlaM Didn't make it this weekend, but did it today.
I will take some time before the fix is published (the update needs to be validated by Google).

@RoelVB RoelVB closed this as completed Sep 7, 2020
@BlaM
Copy link

BlaM commented Sep 8, 2020

Let's see and wait how it works with those multi-step login forms like the one @f1h0 posted from Yandex.

Those might become a problem and I guess they will be more and more common for bigger sites that use federation with big companies (step 1 recognizes if you are coming from company XY and will then send you to the company log in page to actually sign in with your work-login). But to be honest: Those are clumpsy with other password managers as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants