Import aliases

[krlmlr]

I have defined quite a few aliases which I'd like to have available as top-level commands in a Git shell. git-sh had this, would you support this here too?

[krlmlr]

I like the approach of shgit as a much lighter-weight tool that focuses on the main task: the prompt and providing top-level commands. We don't need a Makefile, we don't need opinionated aliases, and it's great to optimize for syscalls for better Windows support. Having my own aliases available is still important to me, though.

[roeme]

Yup, this will be supported, in fact, already is. It seems that I didn't push the corresponding commits here to github. Doing this in a minute.

[roeme]

As of 2e51aff, should work now.

[krlmlr]

Thanks. I'm now seeing:

...
Reading color escapes from git...
bash: ./shgit.sh: line 122: syntax error near unexpected token `git'
bash: ./shgit.sh: line 122: `git diff --ours '

Could my do alias be a problem?

[krlmlr]

After removing that for loop, aliases work for me, but the color in the prompt is gone. Leaving the issue open for now.

[krlmlr]

I see now, the shell mistakes the do as an alias. Maybe use \do ? (OTOH, it's probably not too bright to alias a shell keyword...)

[roeme]

Yeah, this is a bit of a conundrum: I don't want to constrain the user in what kind of aliases can be used, but at the same time, as you correctly pointed out, this clashes a bit with the shell in general. Maybe there's an elegant way out of this. Thinking.

[krlmlr]

I think we can avoid setting aliases that are one of ! case coproc do done elif else esac fi for function if in select then until while { } time [[ ]], with a warning. The alias is still available with e.g. git do, but not as a top-level alias.

(Also, a "quiet" where initialization info isn't shown would be great.)

[roeme]

That is a good idea, and tentatively implemented with 308c7ed

[krlmlr]

Thanks for looking into it!