Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass multiple protocols in rfbOptions.wsProtocols #45

Closed
1 task done
devpilot opened this issue Jul 19, 2023 · 2 comments · Fixed by #47
Closed
1 task done

Pass multiple protocols in rfbOptions.wsProtocols #45

devpilot opened this issue Jul 19, 2023 · 2 comments · Fixed by #47
Labels

Comments

@devpilot
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

If I have multiple protocols to pass its not working out with wsProtocols: string. On noVnc they are accepting array for wsProtocols. this._wsProtocols = options.wsProtocols || [];
https://github.com/novnc/noVNC/blob/295004cabe262367a4df32257d8eb8517bfc4ae1/core/rfb.js#L119

Proposed solution (optional)

Therefore I'm proposing to add wsOptions: string | string[] type in RFBOptions

@roerohan
Copy link
Owner

roerohan commented Aug 1, 2023

Hi @devpilot
Thanks for reporting this issue! I see that you've made the aforementioned change on your fork, and I believe the change you made fixes the issue.

I made a PR for the change from your fork (#47), and I'll merge it into the main branch of this repository. Although I'll test it out on my own too, it would be great if you could confirm that the change works and doesn't break anything.

Thanks again for your contribution to the repository!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🎉 This issue has been resolved in version 0.5.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants