Improve rotation control #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 25, 2022 13:44
It allows to make a relative rotation in the negative direction
Allows to use Controller in a with statement
With the modulo, the rotation stages moves -350° instead of 10° when going from 355° to 365°.
|
These seem like useful changes. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allow a more predictable rotation control.
stage.shift_angle(-5) rotates the stage by 5° ccw
stage.set_angle(355), stage.set_angle(365) work as intended, i.e., shift bu an additional 10° cw instead of 350° ccw
Sorry about the white space changes, those were made automatically by my IDE without me noticing