Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprication of mkpath(x) to makedir(x, recursive=true) does not work if a directory called x already exists #33

Closed
oxinabox opened this issue Nov 29, 2018 · 2 comments

Comments

@oxinabox
Copy link
Contributor

There are 2 differences between mkdir and mkpath

  1. mkpath recursively creates directories
  2. mkpath does nothing if the directory already exists, where as mkdir throws an error.

The deprecation currently only works for case 1.

@oxinabox
Copy link
Contributor Author

Can this be moved to FilePathsBase.jl?

@rofinn
Copy link
Owner

rofinn commented Feb 13, 2019

NOTE: That's what the keyword argument exist_ok should be for. I'm starting to be convinced that we should support the exact same API as base in FilePathsBase to minimize confusion and increase the likelihood that it could become a stdlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants