Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-fela): add FelaTheme to typings #662

Merged
merged 1 commit into from Jan 25, 2019
Merged

fix(react-fela): add FelaTheme to typings #662

merged 1 commit into from Jan 25, 2019

Conversation

layershifter
Copy link
Contributor

Description

Adds FelaTheme to typings, without the render prop as it was deprecated.
http://fela.js.org/docs/api/bindings/FelaTheme.html

Packages

  • react-fela

Versioning

  • Major
  • Minor
  • Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Tested locally in our repo and works like a charm 馃帀

@layershifter layershifter force-pushed the fix/typings-add-felatheme branch 6 times, most recently from 865fc9d to 12f302e Compare January 24, 2019 14:27
@layershifter layershifter mentioned this pull request Jan 24, 2019
Merged
@layershifter
Copy link
Contributor Author

@rofrischmann @TxHawks guys can you help me to get this released soon? 馃樅

@robinweser robinweser self-requested a review January 25, 2019 10:57
robinweser
robinweser approved these changes Jan 25, 2019
View reviewed changes
Copy link
Owner

@robinweser robinweser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robinweser robinweser merged commit 6cdd7c4 into robinweser:master Jan 25, 2019
@robinweser
Copy link
Owner

Out with 10.1.3 :)

@layershifter layershifter deleted the fix/typings-add-felatheme branch January 25, 2019 11:11
@layershifter
Copy link
Contributor Author

鉁岋笍 鉂わ笍 馃槏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinweser robinweser robinweser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@layershifter @robinweser