Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixer removes multiple/fallback values #89

Closed
Swatinem opened this issue Jul 5, 2016 · 7 comments
Closed

Prefixer removes multiple/fallback values #89

Swatinem opened this issue Jul 5, 2016 · 7 comments
Labels

Comments

@Swatinem
Copy link

Swatinem commented Jul 5, 2016

When specifying multiple values, like this:
{ position: [ 'fixed', 'sticky' ] }
only the first alternative is kept after prefixing:
{ position: 'fixed' }

@robinweser
Copy link
Owner

@Swatinem Are you using the dynamic or the /static version?
@rtsao Could this be an issue with your array prefixing PR?

@robinweser robinweser added the bug label Jul 5, 2016
@Swatinem
Copy link
Author

Swatinem commented Jul 5, 2016

Yes, this happened when I was switching from inline-style-prefix-all to inline-style-prefixer/static.

@rtsao
Copy link
Contributor

rtsao commented Jul 5, 2016

If it worked in -all (my PR) it must be some change that occurred when moving to this repo

@robinweser
Copy link
Owner

well prefix-all does not include your PR on npm. I merged that when moving to /static. I got no idea why we should have removed array values before as I did not iterate those at all. But ofc it was just an idea as you actually did this array prefixing recently :P

@rtsao
Copy link
Contributor

rtsao commented Jul 5, 2016

Oh, didn't realize it was never published. Probably should remove it then until a failing test case can be added and bug resolved.

@robinweser
Copy link
Owner

@rtsao Are you talking about removing the array prefixing? I will have a look at that tomorrow. I believe we should keep array prefixing if possible :P

@robinweser
Copy link
Owner

I both fixed the array prefixing and also added array prefixing to the dynamic new Prefixer().prefix. Feel free to update to 2.0.1 :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants