Use regex.test(str) instead of str.match(regex) #115

lencioni · 2017-03-06T04:35:42Z

In all of these places, we really care about a boolean regex match so
we can use the much faster regex.test instead of str.match.

https://jsperf.com/str-match-vs-regex-test/1

At a glance, I see a few more opportunities for performance
improvements (e.g. moving regex declarations up to the module level),
but I'm going to leave them for now.

In all of these places, we really care about a boolean regex match so we can use the much faster regex.test instead of str.match. https://jsperf.com/str-match-vs-regex-test/1 At a glance, I see a few more opportunities for performance improvements (e.g. moving regex declarations up to the module level), but I'm going to leave them for now.

robinweser · 2017-03-06T08:16:40Z

amazing! was not aware of performance differences here :P

Feel free to PR any improvements!

This was referenced Mar 6, 2017

Use hasOwnProperty to check for object properties #116

Merged

Improve importantify() performance Khan/aphrodite#201

Merged

robinweser merged commit cd4d50d into robinweser:master Mar 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use regex.test(str) instead of str.match(regex) #115

Use regex.test(str) instead of str.match(regex) #115

lencioni commented Mar 6, 2017

robinweser commented Mar 6, 2017 •

edited

Use regex.test(str) instead of str.match(regex) #115

Use regex.test(str) instead of str.match(regex) #115

Conversation

lencioni commented Mar 6, 2017

robinweser commented Mar 6, 2017 • edited

robinweser commented Mar 6, 2017 •

edited