Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker build and run targets to Makefile #49

Open
haani-niyaz opened this issue Jul 11, 2022 · 0 comments · May be fixed by #71
Open

Add docker build and run targets to Makefile #49

haani-niyaz opened this issue Jul 11, 2022 · 0 comments · May be fixed by #71
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@haani-niyaz
Copy link
Collaborator

haani-niyaz commented Jul 11, 2022 •
edited
Loading

We should add make docker-build and make docker-run targets to the Makefile since we ship the repo with a Dockerfile.

Acceptance Criteria

  • Add targets
  • Provide a configurable variable to override the registry/image name
@haani-niyaz haani-niyaz added enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2022
@atallison atallison linked a pull request Aug 1, 2022 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@haani-niyaz