Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error when using google.protobuf.Timestamp #13

Closed
zpatrick opened this issue Nov 11, 2020 · 8 comments · Fixed by #15
Closed

Syntax error when using google.protobuf.Timestamp #13

zpatrick opened this issue Nov 11, 2020 · 8 comments · Fixed by #15

Comments

@zpatrick
Copy link

I'm getting a syntax error when trying to specify a google.protobuf.Timestamp. This seems to occur no matter what the input for either startTime or nanos is:

image

@rogchap
Copy link
Owner

rogchap commented Nov 11, 2020

Hmmm, interesting; thanks for reporting; will hopefully get a fix for this soon.

@rogchap
Copy link
Owner

rogchap commented Nov 11, 2020

Ok; I can see the issue: some/most of the Well Known Types have custom marshal/unmarshal functions that I need to account for.

I always planned on better support for Well Known Types, I guess this bug will expedite that!

I think I'll do a quick fix for Timestamp and Duration and plan in the rest later.

@zpatrick
Copy link
Author

Awesome, thanks for the quick reply!

@rogchap
Copy link
Owner

rogchap commented Nov 12, 2020

v0.2.2 has support for Timestamp and Duration.... In the future I'd like to add a Date/Time picker for Timestamp to make it easier to input.

@rogchap
Copy link
Owner

rogchap commented Nov 12, 2020

Looking at your screenshot again @zpatrick I think you are going to have similar issues with the Wrapper types too: BoolValue 😞

Will add it to my list.

@zpatrick
Copy link
Author

ah bummer, sounds good man!

@rogchap
Copy link
Owner

rogchap commented Nov 25, 2020

FYI v0.3.x has support for the wrapper types

@oheyzhiwei
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants