New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RtlsdrAio improvements #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is annoying!
Commits starting from 1e0dbf6 should be squashed since full py version can be specified according to travis-ci/travis-ci#4437 (comment) which I believe could be documented more clearly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly fixes for bugs that were encountered when using the subprocessing and multi-threading
methods that work behind the scenes in py-test (while trying to tackle something mostly unrelated to asyncio).
Since the
read_bytes_async
is called in an Executor, it seems appropriate to ensure that all of the async functions can be handled properly when thestop()
method is called._callback
into the queue using acoroutine
.asyncio.QueueFull
) and log the error.AsyncCallbackIter
to ensure that all remaining coroutines can be "awaited"stop()
method, add test forread_bytes_async
await
expression forstop()
This PR has a lot of ugly commits from fighting with travis-ci and its outdated default python3.5 package (3.5.0.. current stable is 3.5.2). As such, I think it should be a squash merge.